-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic QTI zip loading prototype. #8070
base: develop
Are you sure you want to change the base?
Conversation
8153bf9
to
c4c00bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at this before but realized I never commented. I gave it another pass and everything looks good to me. This will be an excellent foundation to work from
kolibri/plugins/qti_viewer/assets/src/views/AssessmentItemRef.vue
Outdated
Show resolved
Hide resolved
return new URL( | ||
relativeHref, | ||
new URL(this.getFilePath(), 'http://b.b/') | ||
).pathname.substring(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little clarification
return new URL( | |
relativeHref, | |
new URL(this.getFilePath(), 'http://b.b/') | |
).pathname.substring(1); | |
// iterative URL path construction using dummy domain | |
return new URL( | |
relativeHref, | |
new URL(this.getFilePath(), 'http://example.com/') | |
).pathname.substring(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deliberately used a non-valid TLD to avoid any confusion, but yes.
8c58c23
to
7149993
Compare
Summary
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)