Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ensure jobs persist on server restart #8030

Merged
merged 6 commits into from
Apr 28, 2021

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Apr 25, 2021

Summary

#7951 and #7959 changed server behavior to persist jobs across server restarts. This PR adds tests for this new behavior.

The tests are not at all ideal, I would love to hear ways of making it better!

References

Already referenced.

Reviewer guidance

Do these tests mimic server behavior correctly? Does tests pass?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb
Copy link
Member Author

vkWeb commented Apr 25, 2021

cc @rtibbles for review.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the real services plugin for the test.

kolibri/utils/tests/test_server.py Outdated Show resolved Hide resolved
@vkWeb
Copy link
Member Author

vkWeb commented Apr 28, 2021

@rtibbles sir, I have made updates to these tests. Now we are using real services plugin with scheduler integration.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, tests are covering important code paths. Thank you!

@rtibbles rtibbles merged commit 6412ccc into learningequality:develop Apr 28, 2021
@vkWeb vkWeb deleted the tests/server branch April 28, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants