-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cherrypy dependency #8026
Conversation
6db3507
to
8ec7759
Compare
Remove unused dependencies and pin used dependencies.
Simplify stop code. Remove unused dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discovering of the zip port is not working fine, as it's not being assigned. Hashi does not work with this PR (and it did work in #8023)
Tested with PLIX, ASP, H5P... none of the html5 apps works as the browser is not using the right port to get the files:
it tries port 8080 while Zip port is 45739:
INFO Starting on 0.0.0.0:45739
INFO Waiting for 0.0.0.0:45739
INFO Serving on 0.0.0.0:45739
INFO Starting on 0.0.0.0:8080
INFO Waiting for 0.0.0.0:8080
INFO Serving on 0.0.0.0:8080
INFO Registering ourselves to zeroconf network with id '9ad9ee5e19f80c03774f7d3d29dffdc3' and port '8080'
INFO Kolibri running on: http://172.18.0.1:8080/
INFO Kolibri running on: http://172.17.0.1:8080/
INFO Kolibri running on: http://127.0.0.1:8080/
INFO Kolibri running on: http://192.168.0.44:8080/
INFO Bus state: RUN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running it forcing the zip port it works:
KOLIBRI_ZIP_CONTENT_PORT=8081 kolibri start --foreground
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I DO want to delete this review comment but GH does not let me doing it unless I write something :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything works fine, LGTM
Summary
References
Depends on #8023
Fixes #8024
Supersedes #7714
This also contributes to fixing learningequality/kolibri-app#74 in a most general way, by allowing apps to just specify port 0, and allowing a free port to be chosen for use.
Reviewer guidance
Kolibri should run and serve as intended.
Appropriate logging happens for all events in the server life cycle.
Start Kolibri with
--port=0
and verify that the port bound is the one reported, and that zeroconf registers that portTesting checklist
PR process
Reviewer checklist
yarn
andpip
)