Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the outline error in searchbar and On video player (hovering) #7994 #7995

Closed
wants to merge 3 commits into from
Closed

Conversation

Priyaraj17
Copy link
Contributor

Summary

I have fixed the issues of outline which was appearing on some components like searchbar, on video player while hovering.
simplescreenrecorder-2021-04-10_13 56 34
image

References

Issue: #7974

Reviewer guidance

Just need to ensure the changes are visible. The components which are needed to be checked are searchbox and video player Play/Pause button.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@Priyaraj17 Priyaraj17 changed the title My contribution Fixed the outline error in searchbar and On video player (hovering) #7994 Apr 10, 2021
@Priyaraj17 Priyaraj17 closed this Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant