Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to babel. #7987

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Switch to babel. #7987

merged 1 commit into from
Apr 12, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 9, 2021

Summary

  • Many moons ago we switched to buble to speed up our webpack builds
  • Buble is now in maintenance mode
  • Babel seems to have got a lot faster
  • This PR makes us use babel again
  • Unfortunately Babel is still slow for some things, so I added an exclusion for any files marked as 'dist' to avoid transpiling already transpiled code

Reviewer guidance

  • Build completes?
  • Manual testing shows no obvious regressions?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the 0.15.0 milestone Apr 9, 2021
@rtibbles rtibbles requested a review from nucleogenesis April 9, 2021 13:17
@rtibbles rtibbles added the TODO: needs review Waiting for review label Apr 9, 2021
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Babel config expert - but everything here LGTM.

Smoke tested it - no issues with the build completing.

However, Babel is far slower (on my machine anyway) - but I get wanting to use maintained software instead of maintenance mode software moving forward here.

Babel:

Kolibri Build: Initial build complete in 87.608 seconds

Buble:

Kolibri Build: Initial build complete in 55.388 seconds

@rtibbles
Copy link
Member Author

Yeah - unfortunately Babel will never be as quick as Buble because Babel does everything. One advantage is that we can start using async/await in future!

@rtibbles rtibbles merged commit 838e486 into learningequality:develop Apr 12, 2021
@rtibbles rtibbles deleted the babel branch April 12, 2021 21:29
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Apr 13, 2021
@rtibbles rtibbles mentioned this pull request Jun 2, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants