Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab-indent style rule for Gherkin scenarios to the .editorconfig #7956

Merged

Conversation

radinamatic
Copy link
Member

@radinamatic radinamatic commented Apr 6, 2021

Summary

As discussed with @jonboiser, I'm suggesting to specify tab indent style for the pickles, which looks much cleaner in the Gherkins than the spaces, and not have it interfere with the indent styles for code.

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic radinamatic added TODO: needs review Waiting for review TAG: dev experience Build performance, linting, debugging... labels Apr 6, 2021
@radinamatic radinamatic requested a review from jonboiser April 6, 2021 03:08
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonboiser jonboiser changed the base branch from release-v0.14.x to develop April 6, 2021 18:23
@jonboiser jonboiser changed the base branch from develop to release-v0.14.x April 6, 2021 18:23
@jonboiser jonboiser merged commit 43a46aa into learningequality:release-v0.14.x Apr 6, 2021
@jonboiser jonboiser added gherkin update An issue that only requires updating Gherkin stories for a feature and removed TODO: needs review Waiting for review labels Apr 6, 2021
@jonboiser jonboiser added this to the 0.14.7 milestone Apr 9, 2021
@radinamatic radinamatic deleted the editorconfig-pickles branch June 10, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gherkin update An issue that only requires updating Gherkin stories for a feature TAG: dev experience Build performance, linting, debugging...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants