Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to restore the build #7943

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Attempt to restore the build #7943

merged 2 commits into from
Apr 2, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 2, 2021 •
edited
Loading

Summary

  • Install c extensions with no dependencies to prevent conflicts.
  • Explicitly list dependencies in either cext, cext_noarch, or base.

…

Reviewer guidance

Does it build? Do cext tests pass?

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the work-in-progress Not ready for review label Apr 2, 2021
@rtibbles rtibbles requested a review from DXCanas April 2, 2021 00:02
@rtibbles rtibbles marked this pull request as ready for review April 2, 2021 03:24
@rtibbles rtibbles added TODO: needs review Waiting for review and removed work-in-progress Not ready for review labels Apr 2, 2021
rtibbles added 2 commits April 2, 2021 08:02
@rtibbles
Install c extensions with no dependencies to prevent conflicts.
22ac136 
Explicitly list dependencies in either cext, cext_noarch, or base.
Ignore comments in cext.txt.
@rtibbles
Update and enhance tests for crypto.
5e7854e
@rtibbles rtibbles added this to the 0.15.0 milestone Apr 2, 2021
DXCanas
DXCanas approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@DXCanas DXCanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s beautiful 🥺

@rtibbles rtibbles merged commit 7fb314b into learningequality:develop Apr 2, 2021
@rtibbles rtibbles deleted the build_baby_build branch April 2, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DXCanas DXCanas DXCanas approved these changes

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @DXCanas