-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use --skip-update
when running Kolibri in development mode
#7938
Do not use --skip-update
when running Kolibri in development mode
#7938
Conversation
9c4a63e
to
2135cf9
Compare
@rtibbles What needs to be updated in the dev docs? I can just add it to this PR |
@radinamatic had just added this: https://github.com/learningequality/kolibri/blob/develop/docs/getting_started.rst#database-setup because of this exact issue, but with this change it's now redundant :) |
Oh, well... 🤷🏽♀️ Do we need to revert and delete the Database setup step now? |
I removed that section, but added some explanation that the database setup happens as part of the first Hopefully, after this change. The onboarding experience is simple as 1. clone the repo, 2. install deps, 3. |
@jonboiser not seeing the docs updates in this PR, did you push them? |
Whoops, I did not! |
Here's the diff that I did not push 😭 I can revisit this after #7940 is merged, just to make sure the whole onboarding story is documented consistently. |
Have merged #7940 |
Summary
Changes the
devserver
npm scripts to use thepython-devserver
script, which invokeskolibri start
without the--skip-update
flag.This means, when you start Kolibri after deleting your
KOLIBRI_HOME
folder, or updating theKOLIBRI_HOME
variable, etc, running the devserver for the first time will create the dev database and run the migrations first.This also uses the
run-p
shorthand to replacenpm-run-all --parallel
in the 4 scriptsI also updated the "Getting started" guide to explain this change to the onboarding experience as well as the KOLIBRI_HOME env variable.
Reviewer guidance
Check to see that this new script works in different common situations like:
devserver
script.References
Fixes #7302
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)