Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows and macos python 3.6 unit test runners; make filesystem operations safer on Windows #7899

Merged
merged 9 commits into from
Apr 7, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Mar 21, 2021

Summary

Adds windows and macos to unit tests, running only on Python 3.6
Removes use of NamedTemporaryFile as all our usages required opening the file by reference to the filepath which is not supported on Windows (see https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile). Instead uses mkstemp which is safer.

Reviewer guidance

Do tests pass?
Does caching function correctly on new platforms?

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the 0.15.0 milestone Mar 21, 2021
@rtibbles rtibbles added the work-in-progress Not ready for review label Mar 21, 2021
@rtibbles rtibbles force-pushed the windows_macos branch 6 times, most recently from 10aa052 to bc49d6d Compare March 24, 2021 23:15
@rtibbles rtibbles marked this pull request as ready for review March 24, 2021 23:29
@rtibbles rtibbles added TODO: needs review Waiting for review and removed work-in-progress Not ready for review labels Mar 24, 2021
@rtibbles rtibbles force-pushed the windows_macos branch 4 times, most recently from 8b1884f to 5a71cfc Compare April 2, 2021 19:38
@jonboiser jonboiser changed the title Add windows and macos python 3.6 unit test runners. Add windows and macos python 3.6 unit test runners; make filesystem operations safer for Windows Apr 7, 2021
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Apr 7, 2021
@jonboiser jonboiser changed the title Add windows and macos python 3.6 unit test runners; make filesystem operations safer for Windows Add windows and macos python 3.6 unit test runners; make filesystem operations safer on Windows Apr 7, 2021
@jonboiser jonboiser added the changelog Important user-facing changes label Apr 7, 2021
@jonboiser jonboiser merged commit 61bab3c into learningequality:develop Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants