Add windows and macos python 3.6 unit test runners; make filesystem operations safer on Windows #7899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds windows and macos to unit tests, running only on Python 3.6
Removes use of
NamedTemporaryFile
as all our usages required opening the file by reference to the filepath which is not supported on Windows (see https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile). Instead uses mkstemp which is safer.Reviewer guidance
Do tests pass?
Does caching function correctly on new platforms?
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)