Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show resource count at channel level cards while managing lesson resources #7894

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

kmrinal19
Copy link
Contributor

@kmrinal19 kmrinal19 commented Mar 19, 2021

Summary

This PR allows us to see resource count at channel level cards while managing lesson resources. It will help coaches prepare the lesson as they can easily see the channels they are working on.

manage_resource

References

Fixes #7695

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser self-assigned this Mar 19, 2021
@jonboiser jonboiser added this to the 0.15.0 milestone Mar 19, 2021
@jonboiser jonboiser added the APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) label Mar 19, 2021
@kmrinal19 kmrinal19 changed the title Show resource count at channel level cards too while managing lesson resources Show resource count at channel level cards while managing lesson resources Mar 19, 2021
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jonboiser jonboiser added the changelog Important user-facing changes label Mar 22, 2021
@jonboiser jonboiser merged commit b481178 into learningequality:develop Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants