Extract NewPasswordPage from SignInPage, and make new route #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonboiser
added
APP: User
| @@ -72,8 +72,7 @@ function makeWrapper(options) { | |||
| describe('ActivityList component', () => { | |||
| it('on first render, calls the notification resource', async () => { | |||
| const { fetchMock, wrapper } = makeWrapper({}); | |||
| await wrapper.vm.$nextTick(); | |||
| await wrapper.vm.$nextTick(); | |||
| await global.flushPromises(); | |||
Comment on lines
-152
to
-156
| <!-- TODO: This can be its own separate component --> | ||
| <!-- | ||
| Learner was created without a password, but now must create one. | ||
| This ought to be routed separately. | ||
| --> |
nucleogenesis
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NewPasswordPage, which is assigned to a new route/set-passwordglobal.flushPromisesutility, following some advice in these docsnextTick.Reviewer guidance
/set-passwordURL and the learner has already set their password, or theusernamequery param is invalid.References
Closes #7321
(We should write separate issues for the other suggested refactors, since they are a little bit more complicated).
This might add some tech debt because the error states just redirect back to the sign-in page. But this is not a regression since these errors were unhandled originally. We would need some specs on how to be more informative to the user when these errors occur.
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarnandpip)edit