Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in dev docs #7815

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

radinamatic
Copy link
Member

Summary

Reviewer guidance

Build dev docs and check if the links are corrected properly.

References

Fixes #7807


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic radinamatic added TODO: needs review Waiting for review TAG: developer docs Technical docs and code comments labels Feb 25, 2021
@radinamatic radinamatic added this to the 0.14.7 milestone Feb 25, 2021
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonboiser jonboiser removed the TODO: needs review Waiting for review label Feb 25, 2021
@jonboiser jonboiser merged commit 2b6ebad into learningequality:release-v0.14.x Feb 25, 2021
@radinamatic radinamatic deleted the fix-links branch March 18, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: developer docs Technical docs and code comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dead external links in kolibri-dev and kolibri (user) docs
2 participants