Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to the Learn page after updating profile (when prompted by notification) #7778

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented Feb 1, 2021

Summary

Fixes #7362 by updating ProfileEditPage.vue to redirect back to the /learn URL when the user has updated their profile (when prompted by the "Update your profile" notification). See gherkin story:

Scenario: I can go to my profile page from the modal
Given I see the *update your profile* notification modal
When I click the *Edit profile* button
Then I am redirected to the *Edit Profile Page*
And the *Gender* dropdown is empty
And the *Birth year* dropdown is empty
When I fill out the gender and birth year and save (or not)
And I navigate back to the *Learn* page
Then the *update your profile* modal does not appear

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added the changelog Important user-facing changes label Feb 1, 2021
@jonboiser jonboiser added this to the 0.14.7 milestone Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

@metodimilevqa
Copy link

metodimilevqa commented Feb 8, 2021

@jonboiser I confirm the fix is successful. After the user is prompted to update profile info and after this is done, the user is redirected to the Learn page:

Video-2021-02-08-133423

@jonboiser jonboiser merged commit 3608406 into learningequality:release-v0.14.x Feb 8, 2021
@jonboiser jonboiser deleted the redirect-after-profile-update branch February 8, 2021 18:04
@jonboiser jonboiser added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) labels Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Update Your Profile" onboarding would ideally end back at the Learn Page
2 participants