Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full device ID under advanced #7490

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Show full device ID under advanced #7490

merged 1 commit into from
Aug 26, 2020

Conversation

Ali-Kazmi
Copy link
Contributor

@Ali-Kazmi Ali-Kazmi commented Aug 25, 2020

Summary

  • I displayed the full device_id (as given in this.deviceInfo) at the bottom of the advanced section. This is for the device info page.
  • As shown below, it appears to work on chrome. I also tested it on a mobile device and it worked as expected.

After: (for before, please see #7132 )

KolibriDeviceId

Reviewer guidance

  • Test by going to the devices page and clicking on Advanced. See the new item at the bottom of that list.
  • I am not sure if the develop branch is where this task should have gone (I didn't see the task labeled under a milestone, just in the upcoming patch, so I just used the generic develop branch).
  • I couldn't figure out how to label this as needs review, so I could use some help with that if possible. Thanks, I appreciate all the work you guys are doing and i'm hoping to contribute more in the future!

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@Ali-Kazmi Ali-Kazmi marked this pull request as ready for review August 25, 2020 08:28
@jonboiser jonboiser added this to the 0.15.0 milestone Aug 26, 2020
@jonboiser jonboiser added the changelog Important user-facing changes label Aug 26, 2020
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@jonboiser jonboiser merged commit 813946a into learningequality:develop Aug 26, 2020
@jonboiser jonboiser modified the milestones: 0.15.0, 0.14.4 Sep 22, 2020
@jonboiser
Copy link
Contributor

Cherry-picked this to release-0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants