pr/7283 setting doesn't get disabled in valid state

[mdctleo]

Summary

setting doesn't get disabled in valid state #7283

Reviewer Checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[mdctleo]

I can't seem to change label to work-in-progress for this pull request, perhaps due to permission

[indirectlylit]

@mdctleo I've added the work-in-progress label

thanks for your contribution, and let us know when it's ready for review

[codecov]

Codecov Report

Merging #7446 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files	Coverage Δ
...lity/assets/src/views/FacilityConfigPage/index.vue	60.00% <0.00%> (-4.71%)	⬇️
...bri/plugins/learn/assets/src/views/ChannelCard.vue	44.44% <0.00%> (-12.70%)	⬇️
...ibri/plugins/learn/assets/src/views/TopicsPage.vue	25.00% <0.00%> (-2.59%)	⬇️
kolibri/core/lessons/serializers.py	73.40% <0.00%> (-2.56%)	⬇️
...ach/assets/src/modules/classSummary/dataHelpers.js	67.21% <0.00%> (-1.13%)	⬇️
kolibri/core/content/api.py	88.86% <0.00%> (-0.70%)	⬇️
kolibri/utils/server.py	37.02% <0.00%> (-0.13%)	⬇️
...libri/core/assets/src/api-resources/contentNode.js	0.00% <0.00%> (ø)
...plugins/learn/assets/src/views/RecommendedPage.vue	0.00% <0.00%> (ø)
...gins/learn/assets/src/modules/recommended/index.js	0.00% <0.00%> (ø)
... and 18 more

[mdctleo]

@indirectlylit I noticed that the original issue is tagged with frontend:dev, is backend validation necessary for this change? Thanks!

[mdctleo]

@indirectlylit bumping this for review

[indirectlylit]

Thanks @mdctleo

By the way if you aren't in there, feel free to add yourself to https://github.com/learningequality/kolibri/blob/release-v0.14.x/AUTHORS.md

I noticed that the original issue is tagged with frontend:dev, is backend validation necessary for this change?

The tags are definitely not strict.

If you'd like to adding back-end validation (and maybe even a unit test) in addition, that would be great! It's always better to enforce consistency in the API when possible. However the system should also not crash if inconsistent values somehow got set in an older API or DB.