-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update notification styling #7368
update notification styling #7368
Conversation
I actually liked the old version of the notification, it was impossible to miss. This new one is better styled, true, but so easy to overlook 😕 |
This test needs to be fixed here: https://travis-ci.org/github/learningequality/kolibri/jobs/711165802#L8356 It might simply just involve flipping the indices of the paragraphs to get the right text. |
Yes, this does look more prominent 👍 We could discuss adding a different background color for that block (like for old notifications), to make it pop out even more, but this looks OK for now. |
fixed linting, force-merging |
Summary
Reviewer guidance
make sense?
any regressions?
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)