Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to flush sync session data #7313

Merged
merged 3 commits into from
Jul 20, 2020

Conversation

bjester
Copy link
Member

@bjester bjester commented Jul 15, 2020

Summary

When sync sessions do not complete properly, they can leave lots of data in the Morango buffers. This is a command that will easily clean those tables.

Reviewer guidance

Run a few syncs, cancelling them after some has transferred, then run this command.

References

Helps: #7270


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added this to the 0.14.0 milestone Jul 15, 2020
@bjester bjester requested a review from jamalex July 15, 2020 22:36
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #7313 into release-v0.14.x will decrease coverage by 0.31%.
The diff coverage is 10.00%.

Impacted Files Coverage Δ
...ri/core/auth/management/commands/deletefacility.py 0.00% <0.00%> (ø)
...core/auth/management/commands/flushsyncsessions.py 0.00% <0.00%> (ø)
kolibri/core/auth/management/utils.py 40.55% <17.77%> (-7.60%) ⬇️
...libri/plugins/user/assets/src/views/AuthSelect.vue 33.33% <0.00%> (-66.67%) ⬇️
...olibri/plugins/user/assets/src/views/UserIndex.vue 21.05% <0.00%> (-50.83%) ⬇️
kolibri/plugins/user/assets/src/views/AuthBase.vue 28.57% <0.00%> (-47.11%) ⬇️
...ibri/core/assets/src/state/modules/core/getters.js 63.15% <0.00%> (-31.58%) ⬇️
kolibri/core/assets/src/state/modules/session.js 86.20% <0.00%> (-13.80%) ⬇️
kolibri/utils/logger.py 82.50% <0.00%> (-12.50%) ⬇️
...core/assets/src/views/CoreBase/ScrollingHeader.vue 76.08% <0.00%> (-8.92%) ⬇️
... and 26 more

@bjester bjester requested a review from lyw07 July 20, 2020 18:26
Copy link
Contributor

@lyw07 lyw07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and looks good to me!

@lyw07 lyw07 merged commit cb14e87 into learningequality:release-v0.14.x Jul 20, 2020
@jonboiser jonboiser added the changelog Important user-facing changes label Aug 5, 2020
@bjester bjester deleted the flush-syncs branch July 15, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants