Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact name change on the Code of Conduct page #7177

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

radinamatic
Copy link
Member

Summary

Contact name update

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic radinamatic added TODO: needs review Waiting for review TAG: developer docs Technical docs and code comments labels Jun 24, 2020
@radinamatic radinamatic added this to the 0.14.0 milestone Jun 24, 2020
@radinamatic
Copy link
Member Author

This is just one line edited in the dev docs, so build fails should not matter, right?

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@jonboiser jonboiser changed the base branch from develop to release-v0.14.x June 24, 2020 23:12
@jonboiser jonboiser changed the base branch from release-v0.14.x to develop June 24, 2020 23:12
@jonboiser jonboiser merged commit ed42d77 into develop Jun 24, 2020
@indirectlylit indirectlylit deleted the name-change-CoC branch July 6, 2020 19:55
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: developer docs Technical docs and code comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants