Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit post method to device provision call. #7034

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 11, 2020

Summary

Cleanup from #6969 - the device provision call was relying on rest JS' implicit POST behaviour when data is submitted, this adds the explicit POST method to fix device provisioning.

Reviewer guidance

Can you provision the device?

Fixes #7030


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 11, 2020
@rtibbles rtibbles added this to the 0.14.0 milestone Jun 11, 2020
@rtibbles rtibbles requested review from jredrejo and jonboiser June 11, 2020 17:31
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have checked if fixes the issue

@jonboiser jonboiser merged commit 9b29c12 into learningequality:release-v0.14.x Jun 11, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants