More work on Device > Facility page + Setup Wizard + misc fixes #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonboiser
commented
Jun 10, 2020
jonboiser
commented
- Adds WIP facility import/discovery backends on the Setup Wizard
- Integrates Device > Facility Page to existing KDP Sync Backend
- Various fixes
…ration # Conflicts: # kolibri/core/assets/src/views/sync/FacilityNameAndSyncStatus.vue
…ration # Conflicts: # kolibri/plugins/facility/assets/src/views/DataPage/SyncInterface/index.vue
jonboiser
changed the title
Codecov Report
|
jredrejo
reviewed
Jun 11, 2020
| """ | ||
|
|
||
| def retrieve(self, request, pk=None): | ||
| base_url = "http://192.168.1.8:8000/" |
There was a problem hiding this comment.
Using a hardcoded ip is correct?
There was a problem hiding this comment.
No, this endpoint is still being worked on. It will use the DynamicNetworkLocation model's baseurl field to construct the /api/public/v1/facility endpoint for a specific peer.
This hardcoded URL is just my second computer's IP on the LAN, which I'm using for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.