Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix +- buttons wrap behavior in quiz creation for small resolutions #6981

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Jun 3, 2020

Summary

  • do not break questions number buttons (+-) in quiz creation
  • add grid to ensure that +- buttons are always on the same line as input
  • remove obsolete styles from CreateExamPage/index.vue

Small

Before After
Selection_011 Selection_010

Medium

medium

Large

large

Reviewer guidance

Check "Number of questions" input together with +- buttons for various resolutions on quiz creation page.

References

#6893


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added this to the android-mvp milestone Jun 3, 2020
@MisRob MisRob added DEV: frontend bug Behavior is wrong or broken TODO: needs review Waiting for review TAG: mobile Issues related to responsiveness or touch-screens P2 - normal Priority: Nice to have and removed bug Behavior is wrong or broken labels Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #6981 into app-support will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ach/assets/src/views/plan/CreateExamPage/index.vue 0.00% <ø> (ø)

@jonboiser jonboiser self-assigned this Jun 3, 2020
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonboiser jonboiser merged commit 389bdac into learningequality:app-support Jun 3, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jun 3, 2020
@indirectlylit indirectlylit modified the milestones: android-mvp, 0.14.0 Jul 6, 2020
@MisRob MisRob deleted the button-wrap-fix branch June 12, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - normal Priority: Nice to have TAG: mobile Issues related to responsiveness or touch-screens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants