Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mount point detection on Android with latest toolchain. #6885

Merged

Conversation

kollivier
Copy link
Contributor

@kollivier kollivier commented May 18, 2020

Summary

On the Android devices I'm testing on, mount works and returns output in the format defined for the Linux parser. This modifies the detection logic to try that first, then fall back to the RAW_MOUNT_PARSER syntax if it fails.

Reviewer guidance

To test, you need an Android device with external storage, like an SD Card or possibly a USB device. You also need to go into the app settings and enable storage permissions manually until the app support branch has the ability to prompt for permissions.

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@kollivier kollivier requested review from DXCanas and jamalex May 18, 2020 21:37
@kollivier kollivier added the TODO: needs review Waiting for review label May 18, 2020
@kollivier kollivier self-assigned this May 18, 2020
Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visual inspection looks reasonable but i have not tested. Merging in so it doesn't get stale

@indirectlylit indirectlylit merged commit 800ecc5 into learningequality:app-support Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants