-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive video transcript #5631
Merged
bjester
merged 61 commits into
learningequality:develop
from
bjester:interactive-video-transcript
Nov 12, 2019
Merged
Changes from 2 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
da4bd01
Remove yarn.lock file no longer needed
bjester 43c178f
Merge branch 'develop' into interactive-video-transcript
bjester 51d7ae0
Merge branch 'develop' into interactive-video-transcript
bjester b1e8aa2
Refactor creating pattern for breaking out more functionality
bjester 272e2ea
Merge branch 'develop' into interactive-video-transcript
bjester 11b6d95
Track handling and cue display
bjester d47df83
Merge branch 'develop' into interactive-video-transcript
bjester 10745be
Fix css import
bjester 14350e0
Merge branch 'develop' into interactive-video-transcript
bjester 79deece
Add scrolling and responsive positioning of transcript
bjester 3558b6a
Responsive positioning of transcript
bjester 3256ee5
Prevent event loop from setting mode consequences
bjester b12e83c
Labeling and orientation updates
bjester d885cdf
Styling for older browsers
bjester 381d551
Merge branch 'develop' into interactive-video-transcript
bjester ef71d09
Fix theme references
bjester 2800ad1
Merge branch 'develop' into interactive-video-transcript
bjester 1143ca5
Styling updates
bjester 47fb09d
Handle edge case where cue(s) could be larger than viewable area
bjester bba1351
WIP updates to transcript control
bjester cb64e02
Show active language in menu
bjester cfcbd61
Refactor state management, use vuex
bjester d2b4c2f
Remove track additions
bjester 36126ef
Be defensive against no enabled track
bjester 6c42490
Add resetState actions for cleanUP
bjester fffb2b6
Cleanup unused code
bjester 3a9d2c7
Merge branch 'develop' into interactive-video-transcript
bjester 7770bd3
Add more contrast to active cues
bjester 29d0f68
Add more hover contrast to cues
bjester ca87058
Fix merge conflicts
bjester 34d63d6
Post develop merge fixes
bjester d0e33b3
Code review update
bjester 77d7154
Remove empty data
bjester fcf469f
Remove whitespace
bjester 9e440a9
Remove whitespace
bjester d867cd0
Remove transitions and z-indices
bjester de307b3
Remove whitespace
bjester 96d5147
Loading state tweaks
bjester 035a015
Remove line readded in merge resolution
bjester 4f1fffc
Use 100% and watch for fullscreen to better trigger resize
bjester 7329306
Split caption and language menus into separate popups
bjester fb68d18
Merge branch 'develop' into interactive-video-transcript
bjester 6487562
Style fixes
bjester 432320a
Avoid cue overlap on transcript select
bjester 0735d19
Fix merge conflicts
bjester 8699188
Keyboard navigation of custom menus through video.js
bjester c6479d4
Enable subtitles when selecting a language without format enabled
bjester f83afaf
Fix disabling menu without text tracks
bjester 9a90e94
Trigger seek on spacebar
bjester 6231666
Subtitles are enabled by default
bjester 6408e78
Self review updates
bjester 63a95c8
Simplify vuex state, add half-fix for Safari loading issue
bjester ba95106
Fix IE unfriendly scrolling
bjester 4addf6e
Override video.js touch handling interfering with mobile ux
bjester 2a7a80c
Add gherkin story
bjester 4ceef1a
Add Home and End key handling
bjester 84330f6
Always show control bar when navigating by keyboard
bjester afbf81f
Merge branch 'develop' into interactive-video-transcript
bjester eaa4438
Fix subtitle strings for download button
bjester fe5b3c8
Better language handling when navigating between videos with differen…
bjester 0043121
Change event to loadedmetadata
bjester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had tried to add it as a computed prop solely to the media player component, but it wouldn't update. Although, this works even though it's nearly the same.