Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty states to various coach tables and widgets #5051

Merged

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented Feb 13, 2019

Summary

  1. Extends CoreTable to accept an 'emptyMessage' prop, which it renders in a <p> depending on whether it detects any children in its tbody slot.
  2. Updates all of the /coach reports pages that use CoreTable to show an appropriate empty message. (Non-coach pages using CoreTable were not updated)
  3. Updates other list widgets to also show an empty message
  4. Fixes a few tables that was using a "title" header under a column for user names.
  5. Vertically align the table cells in CoachExamsPage Fixes buttons and top alignment in tables don't mix well #5046 (unless the misalignment happens anywhere else).
  6. Fixes Lesson Status Icon always being active Fixes group lesson summary report has status incorrectly reported #5056
  7. Remove the second Needs Help indicator on ItemProgress widget. Fixes redundant 'needs help' indicator in dashboard #5059

screen shot 2019-02-13 at 2 20 35 pm

Reviewer guidance

  1. To manually test, go to as many coach pages as possible and make sure the empty message appears when there is no data, and does not appear when there is data.
  2. In the code, make sure any of use $tr('...') looks correct (i.e. always has coachStrings.$tr and coachstrings is in scope.

References

Fixes #5022

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.rst

Sorry, something went wrong.

@jonboiser jonboiser changed the base branch from develop to release-v0.12.x February 13, 2019 22:28
@jonboiser jonboiser added the TODO: needs review Waiting for review label Feb 13, 2019
@jonboiser jonboiser added this to the 0.12.0 milestone Feb 13, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment fix isn't quite correct because the rows need to be top-aligned for when the text wraps:

image

I think the right fix here is to define a new .core-table-button-col class alongside .core-table-checkbox-col in CoreTable.vue and give those td elements a padding of 4px.

@jonboiser
Copy link
Contributor Author

@indirectlylit Added the core-table-button-col class and applied it to the Exams page and Group page

@indirectlylit indirectlylit dismissed their stale review February 15, 2019 00:37

stale review

@indirectlylit indirectlylit merged commit 12529bc into learningequality:release-v0.12.x Feb 15, 2019
@jonboiser jonboiser deleted the coach-empty-states branch February 19, 2019 19:37
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants