-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty states to various coach tables and widgets #5051
Merged
indirectlylit
merged 9 commits into
learningequality:release-v0.12.x
from
jonboiser:coach-empty-states
Feb 15, 2019
Merged
Add empty states to various coach tables and widgets #5051
indirectlylit
merged 9 commits into
learningequality:release-v0.12.x
from
jonboiser:coach-empty-states
Feb 15, 2019
+110
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonboiser
force-pushed
the
coach-empty-states
branch
from
February 13, 2019 22:40
0bee9c5
to
f2af905
Compare
Codecov Report
|
indirectlylit
previously requested changes
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jonboiser
force-pushed
the
coach-empty-states
branch
from
February 14, 2019 19:37
34ca132
to
2293e08
Compare
@indirectlylit Added the core-table-button-col class and applied it to the Exams page and Group page |
indirectlylit
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<p>
depending on whether it detects any children in its tbody slot.Reviewer guidance
$tr('...')
looks correct (i.e. always hascoachStrings.$tr
and coachstrings is in scope.References
Fixes #5022
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)