Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable "Edit on Github" because it got fixed #2999

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

benjaoming
Copy link
Contributor

Summary

Disabled in #2850
Fixed upstream in readthedocs/readthedocs.org#3203

Has to be sync'ed to develop after.

Reviewer guidance

IMO we should re-introduce it on User Docs, too, until a feedback button is created to replace it.

References

n/a


Contributor Checklist

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • Contributor has fully tested the PR manually
  • Screenshots of any front-end changes are in the PR description
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

@benjaoming benjaoming added TAG: developer docs Technical docs and code comments DOCS: user labels Dec 22, 2017
@benjaoming benjaoming added this to the 0.7.1 milestone Dec 22, 2017
@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #2999 into release-v0.7.x will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v0.7.x    #2999      +/-   ##
==================================================
- Coverage           76.27%   76.11%   -0.16%     
==================================================
  Files                 187      187              
  Lines                7624     7269     -355     
  Branches              983      916      -67     
==================================================
- Hits                 5815     5533     -282     
+ Misses               1624     1557      -67     
+ Partials              185      179       -6
Impacted Files Coverage Δ
kolibri/plugins/setup_wizard/middleware.py 87.5% <0%> (-8.34%) ⬇️
kolibri/core/exams/serializers.py 89.09% <0%> (-4.66%) ⬇️
kolibri/plugins/coach/api.py 86.15% <0%> (-3.39%) ⬇️
kolibri/auth/api.py 90.86% <0%> (-3.38%) ⬇️
kolibri/logger/api.py 96.52% <0%> (-2.19%) ⬇️
kolibri/core/exams/api.py 78.72% <0%> (-1.93%) ⬇️
kolibri/content/api.py 71.17% <0%> (-0.93%) ⬇️
kolibri/utils/server.py 50.36% <0%> (+1.18%) ⬆️
frontend_build/src/prettier-frontend.js 12.85% <0%> (+1.51%) ⬆️
kolibri/deployment/default/urls.py 61.53% <0%> (+8.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45ee44...30fb2a8. Read the comment docs.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@indirectlylit
Copy link
Contributor

have we been able to confirm that the link actually works?

@indirectlylit
Copy link
Contributor

(I'm not sure how to test this without merging in)

@benjaoming
Copy link
Contributor Author

@indirectlylit yes it works, see upstream

@jonboiser jonboiser merged commit c96bd6f into learningequality:release-v0.7.x Jan 11, 2018
@indirectlylit
Copy link
Contributor

very nice

@benjaoming benjaoming deleted the edit-back branch February 26, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: developer docs Technical docs and code comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants