Mastery Mismatch Fix #2354
Mastery Mismatch Fix #2354
Conversation
…ixes learningequality#2089. Removes log at exit (beforedestroy).
|
@rtibbles In my tests, clearing out the log objects at page load for the |
Codecov Report
@@ Coverage Diff @@
## release-v0.4.x #2354 +/- ##
===============================================
Coverage 73.83% 73.83%
===============================================
Files 145 145
Lines 4904 4904
Branches 544 544
===============================================
Hits 3621 3621
Misses 1206 1206
Partials 77 77Continue to review full report at Codecov.
|
| @@ -323,10 +323,6 @@ oriented data synchronization. | |||
| this.$emit('stopTracking', ...args); | |||
| }, | |||
| }, | |||
| beforeDestroy() { | |||
| // Make sure any unsaved data is captured before tear down. | |||
| this.saveAttemptLogMasterLog(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
A clean state would be nice - but my main concern with the current implementation is that we could lose data (we have limited the amount of logging that occurs for performance reasons, so things could get lost by not doing a final save). |
|
Just some confirmation of the race condition |
…hout race conditions. Wiping logging information clean on content page load for safety reasons.
|
@rtibbles updated! |
DXCanas
deleted the
deadly-student-credit-stealing-log-race-condition
branch
Summary
Bad times were had in the making of this PR. Fixes #2253, resolves #2089, fixes #2087, fixes #2252