Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete actually selected channel #1928

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Delete actually selected channel #1928

merged 1 commit into from
Jul 31, 2017

Conversation

christianmemije
Copy link
Contributor

@christianmemije christianmemije added the TODO: needs review Waiting for review label Jul 31, 2017
@christianmemije christianmemije added this to the 0.5.0 milestone Jul 31, 2017
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Issues if fixed in testing. Excellent.

@rtibbles rtibbles merged commit 0570b57 into learningequality:release-v0.5.x Jul 31, 2017
@codecov-io
Copy link

Codecov Report

Merging #1928 into release-v0.5.x will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v0.5.x    #1928      +/-   ##
==================================================
- Coverage           74.09%   74.01%   -0.09%     
==================================================
  Files                 154      154              
  Lines                5610     5610              
  Branches              669      669              
==================================================
- Hits                 4157     4152       -5     
- Misses               1342     1344       +2     
- Partials              111      114       +3
Impacted Files Coverage Δ
kolibri/utils/system.py 32.92% <0%> (-3.66%) ⬇️
kolibri/utils/version.py 70.31% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5525d...3719bd6. Read the comment docs.

@christianmemije christianmemije deleted the deletechannels branch July 31, 2017 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants