Update H5P to latest

[rtibbles]

Summary

• Tweaks our H5P vendoring script to be less restrictive in terms of the files it unzips
• Updates H5P to the latest from upstream
• Fixes CSS url handling for edge cases
• Adds range request support to the zipcontent endpoint, so that we can serve audio and video files from inside archive files
• Allows the zipcontent endpoint once again to serve all recognized archive formats, so we can defer to the zipcontent endpoint for H5P file fetches that we can't intercept to read from our blob URLs.

References

Diff h5p/h5p-php-library@eeefc12...fb5100a

Reviewer guidance

This should be checked against our comprehensive H5P testing channel - but can start with those we have in the QA channel.

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0a0.dev0_git.332.ga1aa2317.pex
Windows Installer (EXE)	kolibri-0.18.0a0.dev0+git.332.ga1aa2317-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0a0.dev0+git.332.ga1aa2317-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0a0.dev0+git.332.ga1aa2317.dmg
Android Package (APK)	kolibri-0.18.0a0.dev0+git.332.ga1aa2317-0.1.4-debug.apk
Raspberry Pi Image	kolibri-pi-image-0.18.0a0.dev0+git.332.ga1aa2317.zip
TAR file	kolibri-0.18.0a0.dev0+git.332.ga1aa2317.tar.gz
WHL file	kolibri-0.18.0a0.dev0+git.332.ga1aa2317-py2.py3-none-any.whl

[pcenov]

Hi @rtibbles - unfortunately none of the H5P resources from the QA channel can be started. Getting the following error in the console:

627-aa1ed38517f4010eb1dc.bundle.js:1 Uncaught URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at 627-aa1ed38517f4010eb1dc.bundle.js:1:4162
    at Function.from (<anonymous>)
    at S (627-aa1ed38517f4010eb1dc.bundle.js:1:3679)
    at e.value (627-aa1ed38517f4010eb1dc.bundle.js:1:4591)
    at t.value (627-aa1ed38517f4010eb1dc.bundle.js:1:11771)
    at 627-aa1ed38517f4010eb1dc.bundle.js:1:13462
    at Array.map (<anonymous>)
    at 627-aa1ed38517f4010eb1dc.bundle.js:1:12492
    at 451-381dff277bf2e6336c0e.bundle.js:1:7339

2025-01-10_14-44-25.mp4

Logs: logs.zip

[radinamatic]

Same here (Chrome and Firefox on Ubuntu 20.04)

[rtibbles]

Bah, thanks, will take a look.

[rtibbles]

Hi @pcenov @radinamatic - I replicated the issue, slightly surprising that it hadn't occurred before this update, but it may be to do with recent updates in develop. Either way, I have fixed it here, as far as I can tell!

[pcenov]

Hi @rtibbles, I confirm that the H5P resources are functioning correctly now.

The following 3 resources from our "H5P testing" channel (piman-fapum) are not loading in both the latest build from this PR and the previous version of H5P, and I'm just mentioning that for the record as it's not caused by the changes made here:

[rtibbles]

Thanks @pcenov - I think I was aware of the 'interactive video' issue - as I suspect that is using an embedded youtube video that we disallow. Worth my taking a quick look at each of them just to confirm whether we can fix them or not though!

[rtibbles]

OK, the iframe embedder should now be fixed. The timeline is working, but with broken images, as it is referencing images hosted on wikipedia, which are blocked/should be assumed missing as they are not locally available, and the interactive video is still broken, as it is referencing an externally hosted video file too.

[rtibbles]

@pcenov this does some small changes to how we serve HTML5 app content as well, so a regression test of HTML5 apps would be helpful here as well (although the fact that it is working for H5P gives me confidence nothing is broken for HTML5 apps).

[pcenov]

Hi @rtibbles, I confirm that the iframe embedder and the timeline are working now (broken images aside)!
No regressions observed on the HTML5 apps as well.