-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid displaying CoachClassListPage until after data is finished loading #12951
Avoid displaying CoachClassListPage until after data is finished loading #12951
Conversation
…the page until after data is finished loading
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and still see the flash.
2024-12-16.13-35-21.mp4
Does the CoachClassListPage have to be loaded at all if there is only one class? I wonder if maybe we could avoid routing to the page altogether in this case?
I was able to prevent loading the CoachClassListCorrect.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and works fine for me. Thanks @LianaHarris360
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM! Thanks Liana
Summary
This pull request handles the brief flash of the
CoachClassListPage
when there's only a single class, after navigating from another plugin to a page in the Coach plugin. The page now renders and displays only after the data is fully loaded. This allows the redirection implemented inclassIdParamRequiredGuard()
to correctly display theCoachClassListPage
only when necessary.Correct behavior:
coachplugincorrect.mov
References
Fixes #12815
Reviewer guidance