Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snackbar errors in content import #12946

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Regression caused by Vue 2.7 upgrade
  • Use the composable in module scope, as can't define setup on a mixin if the consuming component also defines setup.

References

Follow up from #12933

Reviewer guidance

Import content into Kolibri, confirm that snackbars are displayed, without errors, and that redirects happen properly

…if the consuming component also defines setup.
@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend labels Dec 13, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get the "Task finished" snackbar but I don't suspect that is related to your changes here.

I have a video but GH isn't uploading it correctly ping me on Slack if you want it

@pcenov
Copy link
Member

pcenov commented Dec 19, 2024

Yeah, I also confirm that "Task started" is shown correctly every time, but no trace of "Task finished". Checked in Kolibri 0.17.4 and it's not shown there as well, so this might have been broken a long time ago.

@rtibbles
Copy link
Member Author

@pcenov could you file an issue for the lack of Task Finished? Interesting that it's happening in 0.17 as well, because that's before we did a bunch of changes here!

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and w/ the follow-up issue filed this is good to go

@nucleogenesis nucleogenesis merged commit e99a9bb into learningequality:develop Dec 20, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants