-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppBar: Use appBarText for text/icon colors #12937
Merged
rtibbles
merged 8 commits into
learningequality:release-v0.17.x
from
nucleogenesis:themeTokens-appBarText-for-is
Dec 16, 2024
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4ae719c
AppBar: Use appBarText for text/icon colors
nucleogenesis 4c0bee9
Include appBar in themeconfig; validate in themeSpec for appBar image…
nucleogenesis 1851e10
use themeTokens in themeSpec for appbar
nucleogenesis ec00222
Update appbar & sidenav to use appbar themeConfig values
nucleogenesis ad78b7d
fix incorrect uses of themeConfig and themeTokens utilities
nucleogenesis 9e7134e
Remove prop-drilling, just use theemConfig
nucleogenesis c8af4c1
missed default text updated
nucleogenesis d33c457
bump patch version to 0.17.5
nucleogenesis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ | |
|
||
import { validateLinkObject } from 'kolibri.utils.validators'; | ||
import useKResponsiveWindow from 'kolibri-design-system/lib/composables/useKResponsiveWindow'; | ||
import themeConfig from 'kolibri.themeConfig'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to self - this import path will need to be updated when we merge up. |
||
|
||
/** | ||
Links for use inside the Navbar | ||
|
@@ -38,6 +39,7 @@ | |
setup() { | ||
const { windowIsSmall } = useKResponsiveWindow(); | ||
return { | ||
themeConfig, | ||
windowIsSmall, | ||
}; | ||
}, | ||
|
@@ -61,7 +63,7 @@ | |
computed: { | ||
tabStyles() { | ||
return { | ||
color: this.$themeTokens.text, | ||
color: this.themeConfig.appBar.textColor, | ||
':hover': { | ||
'background-color': this.$themeBrand.secondary.v_600, | ||
}, | ||
|
@@ -81,7 +83,7 @@ | |
activeClasses() { | ||
// return both fixed and dynamic classes | ||
return `router-link-active ${this.$computedClass({ | ||
color: this.$themeTokens.text, | ||
color: this.themeConfig.appBar.textColor, | ||
})}`; | ||
}, | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to update it here - but if we are going to remove it from the themeTokens in KDS, might just want this to map to something more directly.