Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionalize hideContinue on whether we are displaying an error or not #12893

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conditionalize hideContinue on whether we are displaying an error or not #12893

merged 2 commits into from
Dec 3, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Ensures we can continue from the SelectFacilityForm component

References

Fixes #12872

Reviewer guidance

In the setup wizard:
Attempt to import a facility from a device with multiple facilities
Attempt to import an LOD user from a device with multiple facilities

@rtibbles rtibbles added this to the upcoming patch milestone Nov 28, 2024
@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend labels Nov 28, 2024
@rtibbles rtibbles changed the base branch from develop to release-v0.17.x November 28, 2024 00:10
@rtibbles rtibbles force-pushed the multiple_facility_continue branch from ac2c0ce to e32b103 Compare November 28, 2024 00:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.17.4.dev0_git.20241203002834.pex
Windows Installer (EXE) kolibri-0.17.4.dev0+git.20241203002834-windows-setup-unsigned.exe
Debian Package kolibri_0.17.4.dev0+git.20241203002834-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.4.dev0+git.20241203002834.dmg
Android Package (APK) kolibri-0.17.4.dev0+git.20241203002834-0.1.4-debug.apk
TAR file kolibri-0.17.4.dev0+git.20241203002834.tar.gz
WHL file kolibri-0.17.4.dev0+git.20241203002834-py2.py3-none-any.whl

@pcenov pcenov mentioned this pull request Nov 28, 2024
Open
nucleogenesis
nucleogenesis approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, thanks for fixing this <3

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Dec 3, 2024
@rtibbles rtibbles merged commit 2869ee5 into learningequality:release-v0.17.x Dec 3, 2024
34 checks passed
@rtibbles rtibbles deleted the multiple_facility_continue branch December 3, 2024 01:04
@rtibbles rtibbles mentioned this pull request Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

Assignees
No one assigned
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend
Projects
None yet
Milestone
upcoming patch
Development

Successfully merging this pull request may close these issues.

0.17.3 - Setup wizard - Cannot import a learner on a LOD from a device with multiple facilities
2 participants
@rtibbles @nucleogenesis