Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer documentation updates #12849

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Nov 15, 2024

Summary

Couple of updates of developer documentation How To Guides in response to volunteer work + small cleanup.

Reviewer guidance

  • Preview the links above
  • Confirm that both options to run Kolibri on a real mobile device work as expected when following step by step

Comments

@nucleogenesis @rtibbles I am not entirely sure how pre-existing https://kolibri-dev.readthedocs.io/en/develop/manual_testing/app_plugin/index.html fits into the mobile device landscape. Does this command simulate Android? If so, should we cross-reference with the new mobile device guide, or place these two pages close to each other, or even have on a single page? And how should I best explain in what cases app plugin is preferred?

@MisRob MisRob marked this pull request as ready for review November 15, 2024 20:16
@MisRob MisRob added the TODO: needs review Waiting for review label Nov 15, 2024
@MisRob MisRob added the TAG: developer docs Technical docs and code comments label Nov 15, 2024
Copy link
Member

@ozer550 ozer550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pointers that I observed while testing this personally.

docs/howtos/preview_on_mobile.md Outdated Show resolved Hide resolved
docs/howtos/preview_on_mobile.md Outdated Show resolved Hide resolved
@rtibbles rtibbles self-assigned this Nov 19, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine here, just need to refine the guidance for getting the IP address - should be instructing people to look out for this logging block from the Kolibri python devserver:

INFO     2024-11-19 15:14:21,967 Kolibri running on: http://A.B.C.D:8000/
INFO     2024-11-19 15:14:21,967 Kolibri running on: http://127.0.0.1:8000/

@MisRob
Copy link
Member Author

MisRob commented Dec 6, 2024

Thank you, I will update.

Any thoughts on this @rtibbles @nucleogenesis?

Screenshot from 2024-12-06 09-35-41

@rtibbles
Copy link
Member

It does not simulate Android in any way shape or form, no - it only emulates our 'app mode' which allows for certain elevated privileges for the logged in user, which we leverage in our apps.

I believe I also update this guidance in this draft PR: #12879

@MisRob
Copy link
Member Author

MisRob commented Dec 16, 2024

Thanks @rtibbles

@MisRob
Copy link
Member Author

MisRob commented Dec 16, 2024

Also just resolved the feedback

@MisRob MisRob requested a review from rtibbles December 16, 2024 14:52
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me - seems like all feedback from other reviewers has been addressed. This all reads very well and I'm thankful for the reminder of this option <3

@@ -335,7 +335,7 @@ To ensure a more efficient workflow, install appropriate editor plugins for Vue.
Sample resources and data
-------------------------

Once you have the server running, proceed to import some channels and resources. To quickly import all available and supported Kolibri resource types, use the token ``nakav-mafak`` for the `Kolibri QA channel <https://kolibri-beta.learningequality.org/en/learn/#/topics/95a52b386f2c485cb97dd60901674a98>`__ (~350MB).
Once you have the server running, proceed to import some channels and resources. To quickly import all available and supported Kolibri resource types, `import with the token <https://kolibri.readthedocs.io/en/latest/manage/resources.html?highlight=import#import-with-token>`__ ``nakav-mafak`` for the `Kolibri QA channel <https://kolibri-beta.learningequality.org/en/learn/#/topics/95a52b386f2c485cb97dd60901674a98>`__ (~350MB).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was pre-existing, but kolibri-beta doesn't exist any more! I think just updating this to kolibri-demo should be fine, although BCK is currently having some difficulties, so I can't be sure!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update this in follow up, so as not to hold this up further!

@rtibbles rtibbles merged commit 8421cf0 into learningequality:develop Dec 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: developer docs Technical docs and code comments TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants