Use webpack's built in dynamic public path setting #12848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn off pathinfo which we deliberately turned off for development, but accidentally left enabled for production, which is not recommended.
github-actions
bot
added
DEV: frontend
DEV: tools
Build Artifacts
|
nucleogenesis
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
- I tested several PDFs and saw no issues
- Ran
find kolibri/ -type f -regex ".*\.\(jpe?g\|png\|gif\|svg\|eot\|woff\|ttf\|woff2\)\$" -size +10kand saw that we have a lot of fonts that are bigger - I see all of those fonts being loaded successfully (including the Mathjax coming from Perseus viewer) - Generally smoke tested various pieces of content and non-Latin-font languages
No issues detected on my end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Webpack 5 introduced built in capability to set the webpack public path dynamically, to allow proper loading of code splitting, and non-inlined assets.
We couldn't use this, as it wasn't compatible with IE11, but since dropping support we can.
Removes an unused IE11 shim in the frontend also.
References
Fixes #9062
Reviewer guidance
Nothing should be different behaviour wise as a result of this. Best things to check are places where we have large assets that should be loaded separately, ensuring they are still loaded as intended.