Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with user not seeing updated practice quiz score on TopicsContentPage #12823

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Nov 12, 2024

Summary

This pull request updates the function setContentNodeProgress() if statement to use the greater than or equal to (>=) operator to allow the user to see the latest practicer quiz score after clicking the back button on the ContentPage.

Previously, if the progress value passed to setContentNodeProgress() equaled 1 and the progress in the contentNodeProgressMap also equaled 1, the function wouldn't update either the contentNodeProgressMap or the contentNodeProgressMetaDataMap, until the page was reloaded.

Before:

Before.mov

After:

After.mov

References

Fixes #12663

Reviewer guidance

  1. Import a practice quiz resource from Kolibri QA Channel > Exercises > Practice quizzes.
  2. Navigate to the practice quizzes Topics Page and take a practice quiz.
  3. Click the "Back" arrow on the TopicsContentPage.

Testing checklist

  • Contributor has fully tested the PR manually

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Nov 12, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - great catch there! I recall being quite frustrated by this issue previously 😅

@LianaHarris360 LianaHarris360 merged commit 15d50f9 into learningequality:develop Nov 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Practice Quiz and clicking back button, user does not see latest score
2 participants