-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on my own merge account KCheckbox issue #12761
Fix on my own merge account KCheckbox issue #12761
Conversation
Build Artifacts
|
Checkbox now has the checkmark! 👏🏽 This has nothing to do with the present PR, but why is the user redirected to Select/Change facility again after signing in with the new credentials after the merge (1:48 in the video below) ? 🫤 checkmark-fixed.mp4 |
Hrm, not entirely clear why it's doing that, it doesn't seem like it's meant to! kolibri/kolibri/plugins/user_profile/assets/src/views/ChangeFacility/MergeFacility.vue Line 285 in 3b49acb
|
Oh, it rather looks like the logging in as the new user is not happening properly, so instead, Kolibri thinks the user's authentication has timed out, and so they are redirected to the auth page (with the next redirect to send them back to where they were). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good to go! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand what is happening in the code here :)
hey @rtibbles! I'm working on this issue, and I was wondering if I could get some help understanding the flow, so it seems like a user successfully mergers an account in the file confrimMerge.vue where does this request/path get sent to? is it suppose to call the LoginMergedUserViewset(APIView)? but it's not doing so? |
Summary
Fix merge account KCheckbox issue
References
Closes #12758
Reviewer guidance
Follow instructions in #12758
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)