Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on my own merge account KCheckbox issue #12761

Merged

Conversation

AlexVelezLl
Copy link
Member

Summary

Fix merge account KCheckbox issue

image

References

Closes #12758

Reviewer guidance

Follow instructions in #12758


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend labels Oct 28, 2024
@radinamatic
Copy link
Member

Checkbox now has the checkmark! 👏🏽

This has nothing to do with the present PR, but why is the user redirected to Select/Change facility again after signing in with the new credentials after the merge (1:48 in the video below) ? 🫤

checkmark-fixed.mp4

@rtibbles
Copy link
Member

Hrm, not entirely clear why it's doing that, it doesn't seem like it's meant to!

@rtibbles
Copy link
Member

Oh, it rather looks like the logging in as the new user is not happening properly, so instead, Kolibri thinks the user's authentication has timed out, and so they are redirected to the auth page (with the next redirect to send them back to where they were).

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to go! 💯 :shipit:

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand what is happening in the code here :)

@rtibbles rtibbles merged commit 713c39c into learningequality:release-v0.17.x Oct 28, 2024
36 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-checkbox-issue branch October 29, 2024 00:05
@emily-dominguez
Copy link

Oh, it rather looks like the logging in as the new user is not happening properly, so instead, Kolibri thinks the user's authentication has timed out, and so they are redirected to the auth page (with the next redirect to send them back to where they were).

hey @rtibbles! I'm working on this issue, and I was wondering if I could get some help understanding the flow, so it seems like a user successfully mergers an account in the file confrimMerge.vue where does this request/path get sent to? is it suppose to call the LoginMergedUserViewset(APIView)? but it's not doing so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants