Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon to be available when the default theme is disabled #12760

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update favicon to be available when the default theme is disabled #12760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...heme/static/assets/default_theme/logo.ico → kolibri/core/static/assets/favicons/logo.ico
View file
Open in desktop
File renamed without changes.
4 changes: 3 additions & 1 deletion kolibri/core/templatetags/core_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ def theme_favicon():

# Choose the first available .ico file. It's unlikely there's more than
# one specified in the theme.
favicon_url = favicon_urls[0] if favicon_urls else static("assets/logo.ico")
favicon_url = (
favicon_urls[0] if favicon_urls else static("assets/favicons/logo.ico")
)

return format_html('<link rel="shortcut icon" href="{}">', favicon_url)

Expand Down
2 changes: 1 addition & 1 deletion kolibri/plugins/default_theme/kolibri_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def theme(self):
},
"logos": [
{
"src": static("assets/default_theme/logo.ico"),
"src": static("assets/favicons/logo.ico"),
"content_type": "image/vnd.microsoft.icon",
"size": "32x32",
},
Expand Down