Dont delete the entire channel when deleting a single content #12740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Force Delete should work as intended now. The node_ids and excluded_ids were not getting validated as the validate for grandparent(ChannelValidator) was invoked in DeleteChannelValidator instead of invoking validate for ChannelResourcesValidator which validates node_ids.
Due to this the deletion was solely based on channel_id only(as node_ids were passed as
none
in deletecontent command) and hence entire channel was getting deletedReferences
Just a small regression introduced by #12680
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)