-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve learn folder contents display #12737
Improve learn folder contents display #12737
Conversation
2762886
to
de8778e
Compare
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rtibbles I confirm that this is implemented as specified, no issues observed while manually testing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I only have questions, I'm not requesting specific changes, although depending on teh answers and how much I'm understanding (or not), I might have some suggestions about tweaks/additions to the code comments for some of the logic.
Prevent display of top level topic resources in subtopic display.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With QA team approval and questions answered, this is good to merge. I do think it's a little bit dense with an array of either an array or objects, but I also think the solution is a good approach. ✅
a3ec15b
into
learningequality:release-v0.17.x
Summary
References
Fixes #9043
Fixes #10060
Reviewer guidance
Look at large topics, small topics, deeply nested topics, topics that have resources and topics interspersed.
Good channels to look at: Kolibri QA channel, the HTML5 topic, Ciencia NASA channel - the Ciencia Espacial
topic.
Folder side panel:
Resources in a topic after a subtopic now have a divider:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)