-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information Architecture Refactor: Update the Plan > Lesson Summary #12730
Merged
marcellamaki
merged 15 commits into
learningequality:develop
from
AlexVelezLl:update-lesson-coach
Oct 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
85eda61
Check tableHasRows for transition-groups
AlexVelezLl 6be46d7
Make report lessons resources table editable
AlexVelezLl 9971b4a
Rename ReportsLessonResourcesTable
AlexVelezLl 0e577b6
Introduce lessonResourcesTable in lessonSummaryPage
AlexVelezLl bb43096
Add functionality to sort and delete resources
AlexVelezLl e0ecd5e
Fix resources backup
AlexVelezLl 385444d
ExportCSV for lesson resources table
AlexVelezLl d645af9
Add learners table
AlexVelezLl 5417769
Modify lesson status and reorganize lesson header
AlexVelezLl 1bb008b
Fix text selection
AlexVelezLl 73c08fa
Avoid reload on tab change and show more options in dropdown menu
AlexVelezLl db54904
Fix styles
AlexVelezLl 638b7b2
Add missing aria labels
AlexVelezLl fce7174
Fix status style
AlexVelezLl 453048c
Fix status style
AlexVelezLl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the work here to handle the resource management within the table, while certainly implied by/part of the spec, is tough, and you did a great job with it. It's a lot more complicated than it would seem just by looking at the UI. And I really like the addition of the snackbar here and the
undo
action. It adds complexity but a really thoughtful implementation for the user perspective.