Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Plans > Lessons landing page to match the new information architecture #12713

Merged

Conversation

LianaHarris360
Copy link
Member

Summary

This pull request implements a /lessonstemp route, designated as a temporary root lessons landing page, utilizing the LessonsRootPage component. It updates the LessonsRootPage table to incorporate "progress" data from reports, while maintaining the existing empty states for unavailable data.

Additionally, it introduces a KSelect filter for "Recipients", as well as print and download buttons, and a class title within the LessonsRootPage component. The new lesson button has also been repositioned to the top of the UI.

Updated LessonsRootPage:

LessonsRootPage

References

Closes #12690

Reviewer guidance

  1. Create a class and lesson(s)
  2. Navigate to the Plan > Lessons tab and ensure the UI changes match the new architecture outlined here

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Oct 9, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, Liana. Sorry this has been waiting and now there's a conflict. Once that's resolved, you can go ahead and merge.

@LianaHarris360 LianaHarris360 merged commit bb7e984 into learningequality:develop Oct 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Plan > Lessons landing page to align with new information architecture
2 participants