Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify saving to device #12675

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Simplifies the logic for saving to device to remove attempt at IE11 compatibility
  • Adds language information to disambiguate subtitle files, rather than using a slice of the checksum
  • Updates version to 0.17.2

References

Fixes #12668

Reviewer guidance

Open a resource (preferable a KA video with lots of subtitles) and ensure in the info side panel that 'save to device' is working for several different files.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the upcoming patch milestone Sep 23, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... DEV: frontend labels Sep 23, 2024
@pcenov
Copy link
Member

pcenov commented Sep 24, 2024

Hi @rtibbles - I confirm that the 'Save to device' option is working correctly without issues for all supported files.

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes and manual QA checks out

@marcellamaki marcellamaki merged commit d935029 into learningequality:release-v0.17.x Sep 24, 2024
34 checks passed
@rtibbles rtibbles deleted the download_attributes branch September 24, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants