Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable Zeroconf in cloud deployments #12620

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Aug 29, 2024

Summary

Adds a ZEROCONF_ENABLED option in options.ini, allowing Zeroconf to be disabled in cloud deployments.

References

closes #10552

Reviewer guidance

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Aug 29, 2024
@ozer550 ozer550 requested a review from rtibbles August 29, 2024 11:03
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, have verified that setting the value to False via an environment variable properly disables the functionality. This is perfectly implemented, and good to go!

@rtibbles rtibbles changed the base branch from develop to release-v0.17.x August 29, 2024 14:55
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, except that it was branched from and targeted to develop. Please rebase this work onto release-v0.17.x!

See https://womanonrails.com/git-rebase-onto for details on doing a very precise rebase and not bringing in develop commits.

@ozer550 ozer550 force-pushed the add-zeroconf-flag-option.ini branch from 2b2a6a6 to f30939d Compare August 30, 2024 06:18
@rtibbles rtibbles merged commit 0d41a14 into learningequality:release-v0.17.x Sep 3, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Kolibri option to disable Zeroconf
2 participants