-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving remaining references to session getters to the useUser composable #12611
Moving remaining references to session getters to the useUser composable #12611
Conversation
74851c3
to
2eb3521
Compare
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the code changes here make perfect sense to me. Just need to manually test to validate.
Ah, looks like merging your useSnackbar PR has given some merge conflicts here! A quick rebase should sort you out. |
2eb3521
to
8b79e1a
Compare
Merge conflicts should be resolved now. |
Thank you, @nathanaelg16! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual testing spot checks show no issues after the updates. Every reference is properly wrapped in get
. This is thoroughly and systematically updated. Great work!
Summary
This change moves the remaining references to the session vuex module getters to the
useUser
composable.References
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)