Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving remaining references to session getters to the useUser composable #12611

Merged

Conversation

nathanaelg16
Copy link
Contributor

Summary

This change moves the remaining references to the session vuex module getters to the useUser composable.

References

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend labels Aug 27, 2024
@nathanaelg16 nathanaelg16 force-pushed the use_user_remaining_references branch from 74851c3 to 2eb3521 Compare August 27, 2024 21:14
@rtibbles rtibbles self-assigned this Aug 28, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes here make perfect sense to me. Just need to manually test to validate.

@rtibbles
Copy link
Member

Ah, looks like merging your useSnackbar PR has given some merge conflicts here! A quick rebase should sort you out.

@nathanaelg16 nathanaelg16 force-pushed the use_user_remaining_references branch from 2eb3521 to 8b79e1a Compare August 28, 2024 18:48
@nathanaelg16
Copy link
Contributor Author

Merge conflicts should be resolved now.

@rtibbles
Copy link
Member

Thank you, @nathanaelg16!

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing spot checks show no issues after the updates. Every reference is properly wrapped in get. This is thoroughly and systematically updated. Great work!

@rtibbles rtibbles merged commit 8bdd729 into learningequality:develop Aug 28, 2024
34 checks passed
@nathanaelg16 nathanaelg16 deleted the use_user_remaining_references branch August 28, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants