Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded TotalPoints component from core API. #12600

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Updates single reference, removes from core API

References

Fixes #12599

Reviewer guidance

As long as import linting isn't broken, this seems fine to merge.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis self-requested a review August 26, 2024 16:25
@nucleogenesis nucleogenesis self-assigned this Aug 26, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I looked around the code to double check if this could impact anything else but all LGTM

@rtibbles rtibbles merged commit 7207bf2 into learningequality:develop Aug 26, 2024
34 checks passed
@rtibbles rtibbles deleted the nil_points branch August 26, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TotalPoints component from the core API
2 participants