Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing legacy vuex module for monitoring connection #12594

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

nathanaelg16
Copy link
Contributor

Summary

As part of my previous PR, connection monitoring has been moved away from using vuex state in favor of a composable that manages state globally. This PR removes the legacy vuex module that should no longer be in use.

References


Testing checklist

  • [X ] Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct - manually tested and everything is fine. Manually ran linting, and no imports were undefined after this!

@rtibbles rtibbles merged commit 867307f into learningequality:develop Aug 26, 2024
34 checks passed
@nathanaelg16 nathanaelg16 deleted the use_connection branch August 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants