Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core channel state into coach - the only place it is still used. #12574

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Moves core channel state into the coach pluginModule

References

Fixes #12557

Reviewer guidance

Does the minimal fix to move the channel fetching logic from the core vuex state into coach.
Will presumably be cleaned up in the future by other changes.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 20, 2024
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Aug 20, 2024
@marcellamaki marcellamaki self-assigned this Aug 20, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading through, the code changes make sense, but I get the following error when trying to navigate into an existing lesson. So, something with the state on the lesson summary page.

Screenshot 2024-08-29 at 11 07 07 AM

If I create a new lesson, I'm able to open the lesson page, and open up manage resources, etc.

I also tried on develop to confirm that this wasn't a regression that was introduce there, and I'm able to open the same (existing) lesson in my class without issue.

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates seem to have resolved the issue! Manual QA checks out -- thanks

@marcellamaki marcellamaki merged commit 65db937 into learningequality:develop Aug 29, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove core vuex channel fetching logic and state and move to coach
2 participants