Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pex filenames #12451

Conversation

rtibbles
Copy link
Member

Summary

This appears to have been an inadvertent regression from our introduction of flake8-print - as the logging was not configured, the logging messages went nowhere. Reverts to print and adds noqa flags.

Removes reliance on writing to VERSION file which should only really be used for the whl file, and gets rid of intermediate make step.

References

Fixes #12440

Reviewer guidance

Does the pex file have a name? Does the name correlate to the names of the other assets? If so, all is well.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 16, 2024
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jul 16, 2024
@marcellamaki marcellamaki self-requested a review July 22, 2024 16:52
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pex file is named properly in built assets

@marcellamaki marcellamaki merged commit a00baa8 into learningequality:release-v0.17.x Jul 29, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants