-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle edge cases for resource selection in quizzes #12444
Handle edge cases for resource selection in quizzes #12444
Conversation
…s are selected. More prominently show the max selectable questions warning.
Build Artifacts
|
Hi @rtibbles I've confirmed that this is working correctly now in Chrome, Firefox, Edge and Safari. My only problem is that the max selectable questions warning says '10 questions or fewer' while at the bottom of the page we see '17 questions selected': |
Agreed, confusing indeed... We may know that this actually translates to: You selected (1 resource with) 17 questions of which 1 will be added (because you specified in the field you want to add just 1) However, the way these numbers are presented in the UI, plus the alert about max number, just leaves the user 🤔 |
Maybe we remove the warning banner for the edge case? I realize this isn't what we had previously concluded Richard... I honestly am not sure what the best path here is. I agree that it's confusing, and that we're somewhat constrained with finding a "least confusing" option for release. |
I think the simplest solution is merely to make the warning banner a max of: number of selected questions, and our maximum. Hiding the banner would be a problem, as it would then remove the explanation as to why no other resources are selectable. |
works for me |
🎉 Screencast.from.07-16-2024.10.57.14.AM.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
References
Fixes #12443
Reviewer guidance
Navigate to a folder in a channel that only has exercises that have more than 10 questions.
Change the number of questions to be selected to "1".
See that each individual resource is still selectable, but that select all is not shown, and the warning text is displayed.
Select one resource.
See that all other resources are now disabled for selection.
Scroll down through the folder, and see that the warning text is displayed 'stickily', so that the warning is displayed prominently. (Note, this may not work on all browsers, but is intended as a progressive enhancement where supported).
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)