EQM: Fix unlinted files #12428
Merged
EQM: Fix unlinted files #12428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Learn
|
Interestingly, when I discovered it, GitHub checks passed. But local linter revealed issues. |
Build Artifacts
|
There was a problem hiding this comment.
@nucleogenesis these changes look fine, but when I run locally, I still have some linting errors. Did you notice anything else locally?
On a more meta level, I feel a little bit confused about why we seem to all be running into different local linting errors
|
@marcellamaki Are the extra errors you see coming from |
|
Oh yes, okay. I didn't realize this wasn't rebased on top of that -- sorry that I didn't totally follow the division of the work between those PRs. This should be fine then. Thank you! |
marcellamaki
approved these changes
Jul 10, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In her work on #12427 @MisRob discovered that the file she'd updated had some extant linting issues that somehow got past the guards.
She fixed the ones in QuestionListPreview in that PR, here I fix the other two files for which I found linting errors when running the linter locally.
Reviewer guidance